"Implement connection limit for WebSocket connections" #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 89.24% 90.63% +1.39%
==========================================
Files 20 20
Lines 818 844 +26
==========================================
+ Hits 730 765 +35
+ Misses 66 58 -8
+ Partials 22 21 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to limit the number of active WebSocket connections in the ConnectionRegistry. It introduces a new method,
CanAccept(), which checks if the registry can accept new connections based on the specified connection limit. If the connection limit is reached, a "Connection limit reached" error message is returned. TheAddConnection()method has been updated to check the connection limit before adding a new connection. Additionally, a new option,WithConnectionLimit(), has been added to set the maximum number of connections that can be accepted by the ConnectionRegistry.